fix(client): deprecate WithResponseTimeout in favor of WithResponseTimeoutDuration #212
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsAreku
force-pushed
the
dev/response_timeout_unit
branch
from
c91f709 to
b0ef0e1
Compare
Author
|
@andreykaipov tests are failing on an unrelated line: Line 151 in b0ef0e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WithResponseTimeoutoption expects a number of milliseconds typed astime.Duration, which is not idiomatic in Go.This PR adds a new
WithResponseTimeoutDurationthat takes a propertime.Durationvalue.This preserves backward compatibility while fixing the semantic mismatch.